-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: added visible long flag aliases in help #6068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will probably have to update the ui tests as well |
I updated the ui testes as well in a separated commit |
@epage I added the |
3e48808
to
77d6cf5
Compare
Hi @epage, I have an issue in the CI because the test I made has the help to wide and I think it wraps. I tried to fix this, by setting I am still looking for a solution, in case you see this before I solve it, your help and guidance will be appreciated as always. |
4aef513
to
6873aaa
Compare
@epage I saw in the code that I added one more test to check all the aliases (visible or not) are working, and I gated the tests for visible aliases under the feature Let me know if this is good now. |
Yeah, I'd have to dig more into the wrapping issue. Should be good for now though. Besides the test issue, this all looks good. Thanks! |
Hi @epage, I fixed the test issue. |
Thanks! |
fix #6067
fix #6073