Skip to content

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Apr 28, 2025

Suggested merge commit message (convention)

It's an epic branch for all the changes regarding documentation redesign.

Tip

We aim to merge this pull request on Monday, 21 July.


Additional information

Issue: #18875
Commercial PR https://github.com/cksource/ckeditor5-commercial/pull/7408
Part of https://github.com/cksource/umberto/pull/1259

@pszczesniak pszczesniak changed the base branch from master to stable July 15, 2025 08:03
@Mati365 Mati365 marked this pull request as ready for review July 15, 2025 10:14
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mati365 Mati365 merged commit 7d86621 into stable Jul 21, 2025
9 checks passed
@Mati365 Mati365 deleted the gloria branch July 21, 2025 05:01
Mati365 added a commit that referenced this pull request Jul 21, 2025
* Add theme page.

* Add missing flag.

* Add legacy to theme.

* Remove no longer used build warning banner.

* Add base promobar config.

* Remove `globals.scss` file.

* Load ckeditor styles on `editor` layer.

* Fix link in promobar.

* Fix promobar link

* Add `ck:badge` to features description.

* Remove legacy tabs.

* Remove ToC from Theme page.

* Replace download emoji.

* Fix skip API

* Remove ⚠️  icon from info callouts.

* Remove ⚠️  icon frommore  info callouts.

* Add code snippet example.

* Added docs global.css.

* Set viewport top offset variable to match exactly the header height.

* Set viewportOffset.top based on media query using matchMedia.

* Add algolia app id.

* Added banner.

* Update CTA banner in theme markdown.

* Added CTA builder banner.

* CTA banner v2.

* Typos fixes.

* Use gloria tooltips manager to attach tooltips.

* Adjust parameters of tooltips.

* Destroy tooltip after focusing editor.

* Switch tooltips to `mount` mode.

* Adjust parameters of tooltips.

* Add icon to tooltip.

* Re-enable tour balloons on mobile.

* Add ToC in guides where it was set to false.

* Highlight the markdown output by shiki.

* Fixed issue with highlighting markdown output.

* Fix code snippets in the Getting and setting data guide.

* Style the Getting and setting data demo.

* Fix formatting.

* Fix the Document title demo.

* Added size class to snippet.

* Use prerendered code-block component in markdown snippet.

* Update the Document title demo with new code blocks.

* Update the Getting and setting data demo with new code blocks.

* Fix update placeholder button in editor-placeholder demo.

* Fix html-embed demo.

* Use fake console in base64 upload.

* Add copyable attributes.

* Change the structure of the Document title demo.

* Add initial values to the Document title demo.

* Fix typo.

* Add throttling to the Document title demo.

* Fix function call in the Getting and setting data demo.

* Update the editor placeholder demo.

* Improve base64 demo output content

* Fullpage snippet update.

* Mark `build-source-` snippets as empty.

* Fix media embed snippets.

* Fix paste from markdown demo.

* Fix page break snippet.

* Fix inspector snippet.

* Fix read-only snippet.

* Add newline

* Improve word count snippet.

* Improve word count styling.

* Add missing classes

* Remove radius from word count demo.

* Fix bootstrap ui snippet.

* Use design system input in images inserting.

* Add restricted editing checkboxes.

* CSS fix.

* Fix styling of the UI components guide.

* Adapt demo in the Using react in a widget guide.

* Adapt demo in the Drag and drop guide.

* Replace class to show some callouts only on mobile view.

* Fix snippets indentations in the Schema guide.

* Remove npm badges from guides.

* Fixes for mini-inspector styles.

* Fixed indentation in menu bar guide code snippet.

* Fix the document editor example by increasing the toolbar z-index by 1.

* Fixes in examples snippets.

* Fix inline demo heading margins.

* Fixes in global.css docs styles.

* Report issue widget config update.

* Restructure the accessibility guide.

* Place feature digest in cards.

* Remove feature digest snippet.

* Remove learn more buttons from feature digest.

* Remove hrefs from headings in Feature digest.

* Shorten links in feature digest.

* Put feature digest cards in columns.

* Add IDs to headings in Feature digest.

* Change links to relative in the Feature digest guide.

* Add target blank to an external link.

* Style Plugins in CKEditor 5 tables a bit.

* Add badges to features.

* Test card nesting.

* Revert Feature digest.

* Wrap Feature digest button links in card descriptions.

* Wrap feature digest links in card footers.

* Hotfix autosave snippet.

* Wrap headings with badges.

* Add the default badge to the Plugins table.

* Unify class names in the Plugins table.

* Docs: Shorten the tooltip message.

* Remove npm badges from API docs.

* Rewrite the "Git commit message convention" guide.

* Rename: Git commit message convention => Changelog entries.

* Typo.

* Wording.

* Unified whitespaces.

* Apply suggestions from code review



* s/-/–

* Switch to the new changelog generator.

* New GH template.

* Simplify the "Creating a pull request" section in the "Contributing" guide.

* Docs: a review. [short flow]

* Update docs/framework/contributing/changelog-entries.md

* Update snippets' extensions in the Angular guides.

* Update snippets' extensions in the Vue guides.

* Tweak the copy.

* Remove theme page.

* Fix W3C errors.

* Use  Docker executor instead of Machine executor on CI

* Update docs/framework/contributing/changelog-entries.md

* Use headless Chrome to run automated tests on CI

* Clone with `--depth 1`

* Display errors when building the editor for docs

* Fix the code blocks snippet.

* Fix for HTML validator.

* Removed duplicated full page html from feature digest.

* Removed duplicated html support from feature digest.

* Added missing parentesis in link.

* Hotfix before the gloria deploy.

* Add missing snippet id.

* Fix typo

* An empty commit for skipping CI. [skip ci]

* Use the latest CKEditor 5 Inspector.

* Fix autoformat demo

* Add line-height section to feature digest

* Tip easter egg.

* Fix the snippet in a tutorial.

* Fix wrong `issueUrl` in docs.

* Fix the big margin in the dll builds guide.

* Cke4 compatibility table style.

* Cke4 compatibility table code snippets fixes.

* CKE4 plkugin equivalent table style fix.

* One more tip.

* Update notification popup.

* Fix docs table wrapper.

* Use `afterReady` in snippets that use umberto API.

* Prevent survicate errors

* Fix typo in getting and setting data

* Update Minimap styles snippets.

* Switch to Umberto v8.

---------

Co-authored-by: Piotr Szczęśniak <[email protected]>
Co-authored-by: Mateusz Gorzeliński <[email protected]>
Co-authored-by: Witek Socha <[email protected]>
Co-authored-by: Kamil Piechaczek <[email protected]>
Co-authored-by: Filip Sobol <[email protected]>
Co-authored-by: Bartek Biedrzycki <[email protected]>
Co-authored-by: CKEditor Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants