Add Max_days parameter to limit how many days we can query from VS: CRASM-3169 #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limit date range for vs sync
fix type on variable import
DJensen94
requested review from
aloftus23,
cduhn17,
nickviola,
rapidray12 and
schmelz21
as code owners
cduhn17
reviewed
Oct 23, 2025
| ) | ||
|
|
||
| # NEW: MAX_SCAN_DAYS-day validation | ||
| date_diff = parsed_end - parsed_start |
There was a problem hiding this comment.
Logging: On both attempts and successes, log user id, request id, scan id, and any rejected fields as structured JSON. This will help now and in future Opentelemetry efforts so we have metrics to get
There was a problem hiding this comment.
addressed in the following commit: f52b1f2
Add detailed logging to date validation
rapidray12
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
limit date range for vulnScanningsync
🗣 Description
Update the recently added date pickers on the VS scan to ensure a user cannot pick more days of data than the MAX_SCAN_DAYS parameter then the frontend will reject the input and the backend will result in a 400 error.
This PR also simplifies the date pickers so it does not include future dates and defaults to the default date selection.
💭 Motivation and context
This change is to ensure the users do not select more data than the scan can handle. It also simplifies users data selection, simplifying the choices to ensure they don't pick dates in the future that don't make sense for the scan type.
🧪 Testing
Tested locally
✅ Pre-approval checklist