Terms Of Use Refactor CRASM-3304

[RKohler21]

🗣 Description

This is a multi Purpose PR that closes both CRASM-3304 and CRASM-3290. For CRASM-3304, this PR contains a full refactor for our Terms Of Use page as well as the deletion of deprecated code from AuthForm and the removal of the /terms URL from our Route file. For CRASM-3290, this PR includes an fix that will resolve the issue of the First Login popup not appearing after accepting the terms of use but later appearing on the second login.

💭 Motivation and context

This PR includes updates/fixes for both PR's since they are heavily related to one another and will improve the flow of our code and UI experience going forward.

🧪 Testing

In order to test, the user will need to follow these steps when logging in for the first time on a new account.

1. Login > Select State > Logout.
2. Login again > View and agree to Terms Of Use > First Login popup will appear > Logout
3. Login one final time > First Login popup will no longer appear

📷 Screenshots (if appropriate)

Before refactor:

After refactor:

Warning Label Addition:

✅ Pre-approval checklist

• This PR has an informative and human-readable title.
• Changes are limited to a single goal - eschew scope creep!
• All future TODOs are captured in issues, which are referenced in code comments.
• All relevant type-of-change labels have been added.
• I have read the CONTRIBUTING document.
• These code changes follow cisagov code standards.
• All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
• Tests have been added and/or modified to cover the changes in this PR.
• All new and existing tests pass.
• Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
• Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

• Revert dependencies to default branches.
• Finalize version.

✅ Post-merge checklist

• Create a release (necessary if and only if the version was bumped).

[ameliav]

I'd suggest moving the TermsOfUse.tsx file to the components/Dialog folder since it's not really a page anymore and removing the TermsOfUse folder under pages.

[jsalinasnttdata]

A few things to address

[jsalinasnttdata]

@RKohler21 We need to add a warning when a user tries to submit without checking the acknowledgment checkbox. See the example below. We’ll likely want to adjust the design since the current alert appears off to the side.

@RKohler21 was this addressed?

[rapidray12]

Was this tested for 508 compliance

[ameliav]

Looks 508 compliant to me

[ameliav]

LGTM

[rapidray12]

Second time around. Looks good