Fix #965 - Make Flapping Ignore Commanded Stops #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding commanded_reap flag to the reap message and setting flapping to only trigger when the flag is True. The flag is false when reaping a processes that was detected dead.
BrainBot
force-pushed
the
965-flapping-fix
branch
from
2b0e702 to
89741ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reap messages now included a commanded reap argument that is True when a process has been reaped because of a Circus command. Processes that have been reaped because they've been detected as dead or killed have the argument set to False. This allows the flapping plugin to detect when a process has been stopped intentionally and not automatically trigger a restart.