docker: Remove docker builder test #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
pr/tammach/ci-simplify
branch
3 times, most recently
from
69ce283 to
a2ae098
Compare
This is same as Docker.builder (except ubuntu version), let's keep one only to avoid multiple build steps. Signed-off-by: Tam Mach <[email protected]>
Using pull_request_target makes the testing hard, also we can merge these two jobs in the same workflow.
Signed-off-by: Tam Mach <[email protected]>
sayboras
force-pushed
the
pr/tammach/ci-simplify
branch
from
a2ae098 to
b2011b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to simplify the existing docker builder and testers. Please refer to individual commit for more details.
Testing was done in the PR, except release workflow (which is only triggered in main).