Fix docker credentials setup in CI #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hadrien Patte <[email protected]>
Artyop
approved these changes
Aug 26, 2025
tklauser
approved these changes
Sep 16, 2025
HadrienPatte
added a commit
to cilium/cilium
that referenced
this pull request
Sep 16, 2025
This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]>
HadrienPatte
added a commit
to cilium/cilium
that referenced
this pull request
Sep 16, 2025
This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]>
HadrienPatte
added a commit
to cilium/cilium
that referenced
this pull request
Sep 16, 2025
This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]>
HadrienPatte
added a commit
to cilium/cilium
that referenced
this pull request
Sep 16, 2025
This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]>
joestringer
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 16, 2025
This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]>
joestringer
reviewed
Sep 17, 2025
pippolo84
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 22, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
pippolo84
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 22, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
pippolo84
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 22, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
pippolo84
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 22, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
pippolo84
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 22, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
pippolo84
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 26, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
pippolo84
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 26, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
pippolo84
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 26, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 26, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 29, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
pippolo84
pushed a commit
to cilium/cilium
that referenced
this pull request
Oct 6, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Oct 6, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <[email protected]> Signed-off-by: Fabio Falzoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CI config to prevent the issue described in #385 from happening.
The latest version of the
makerimage, used in CI to build images, has a broken docker credentials setup. This PR does the following:docker/login-actionaction to handle login in and out of quay.io in CIimage-tools/images/maker/Dockerfile
Line 57 in c5bf38b
makerimage so we don't need to remove this file like that on every CI job.We can observe that this PR works as all the jobs successfully detect that images already exist and don't need to be rebuilt: