Skip to content

Conversation

lmb
Copy link
Collaborator

@lmb lmb commented Mar 10, 2025

ci: log chosen workflow run

Add debug logging to make it clear from which workflow run the efW runtime
is downloaded.

Signed-off-by: Lorenz Bauer <[email protected]>

efw: configure CRT error reporting

The Windows C runtime validates parameters passed to common functions. An
assertion is raised if an invalid parmeter is detected. By default, 
assertions are presented as a graphical message box. Displaying a message
box hangs on systems without a UI, such as our CI.

Configure the debug runtime to log assertions to stderr instead of showing a
dialog. Try to avoid stepping on application specific debug handlers in the
process.

Signed-off-by: Lorenz Bauer <[email protected]>

@lmb lmb force-pushed the ci-debug-windows branch 4 times, most recently from 0926ba5 to 245027b Compare March 10, 2025 16:11
@lmb lmb changed the title ci: log chosen workflow run efw: configure CRT error reporting Mar 10, 2025
@lmb lmb force-pushed the ci-debug-windows branch from 245027b to 1be0796 Compare March 10, 2025 16:16
@lmb lmb marked this pull request as ready for review March 10, 2025 16:23
@lmb lmb requested a review from a team as a code owner March 10, 2025 16:23
@lmb lmb merged commit b45f034 into cilium:main Mar 10, 2025
17 checks passed
@lmb lmb deleted the ci-debug-windows branch March 10, 2025 16:23
lmb added 2 commits March 10, 2025 14:13
Add debug logging to make it clear from which workflow run the efW
runtime is downloaded.

Signed-off-by: Lorenz Bauer <[email protected]>
The Windows C runtime validates parameters passed to common functions.
An assertion is raised if an invalid parameter is detected. By default,
assertions are presented as a graphical message box.
Displaying a message box hangs on systems without a UI, such as our CI.

Configure the debug runtime to log assertions to stderr instead of
showing a dialog. Try to avoid stepping on application specific debug
handlers in the process.

Signed-off-by: Lorenz Bauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant