This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Support enum values with prefix #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change adds support option that trims enum name prefix from enum values.
This is for the case when the proto file is written according to Google Protobuf Style Guide recommendation. This suggest prefixing enum values instead of surrounding them in an enclosing message.
Example:
When this new option is enabled, it will produce something like this:
NOTE: There is one additional commit which is related to imports. The
make fmtcommand changes existing imports, but I decided on a separate commit because it would seem it was not run before (maybe for some reason).Also, when running
make fmton existing code, it changes one additional file, generatedoptions.pb.go, which should not be modified, but it seems likegoimporttool does not ignore generated files. I would suggest updating command call to something like this:P.S.
Sorry for not opening an issue first. I figured this was small change and would be fine to just create pull request for.