-
Notifications
You must be signed in to change notification settings - Fork 594
Add from_timestamp_secs method to DateTime
#1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
+ Coverage 90.78% 90.79% +0.01%
==========================================
Files 39 39
Lines 16231 16254 +23
==========================================
+ Hits 14735 14758 +23
Misses 1496 1496 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
81744ea to
69b1f24
Compare
|
I slimmed down the tests, refactored the existing code to use |
Please squash your commits into a single one. |
Add a new single-argument function for creating a `DateTime` from a Unix timestamp, to match `from_timestamp_micros`, `from_timestamp_millis`, and `from_timestamp_nanos`. Refactor existing code and examples to use `DateTime::from_timestamp_secs` and `DateTime::from_timestamp_millis` where possible. Issue chronotope#1716 Suggestion: add DateTime::from_timestamp_secs function
69b1f24 to
fd92d74
Compare
|
Relocated and squashed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add a new single-argument function for creating a
DateTimefrom a Unix timestamp, to matchfrom_timestamp_micros,from_timestamp_millis, andfrom_timestamp_nanos.Resolves #1716 Suggestion: add DateTime::from_timestamp_secs function