Fix incorrect parsing of fixed-length second fractions #1705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing, the "fixed-length decimal fraction" specifiers (
%.3f,%.6f,%.9f) are currently treated identically to the variable-length specifier (%.f).This causes issues when the fractional part is immediately followed by more digits signifying something completely different (you might think this bizarre, and I would agree, but I've seen upsetting things in vendor-specific log formats).
This PR changes the parser for those specifiers to consume only the exact number of digits specified, returning
TooShortif there aren't enough. Test cases added for all three.Fixes #1592.