Skip to content

Conversation

@pitdicker
Copy link
Collaborator

The first commit makes the iso_week_from_yof function a method on IsoWeek.
The next changes it to consume an ordinal and year_flags instead of Of, and inlines the functionality that was in Of::isoweekdate_raw.

The others move over the weekday and year_flags getters to NaiveDate.

@codecov
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5ba8ed1) 91.84% compared to head (df2e6f7) 91.84%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/naive/date.rs 95.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1431   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files          38       38           
  Lines       17628    17571   -57     
=======================================
- Hits        16190    16138   -52     
+ Misses       1438     1433    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitdicker pitdicker merged commit 7c4b119 into chronotope:main Feb 12, 2024
@pitdicker pitdicker deleted the refactor_internals_3 branch February 12, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants