Improve filtering #218
Open
Improve filtering #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
commented
Jul 18, 2025
parse-zoneinfo/src/structure.rs
Outdated
There was a problem hiding this comment.
I think this file should be moved to chrono-tz-build, it's very codegen specific, i.e. the module docs explain how this behaves in terms of generating code.
However, this would be the next semver breakage for parse-zoneinfo 🙈
There was a problem hiding this comment.
Makes sense to me. Want to move that around in a separate commit?
robertbastian
force-pushed
the
filter
branch
4 times, most recently
from
be10af8 to
ca110e6
Compare
|
Would be nice to split this into smaller commits/PRs so it has less stuff going on all in the same commit. |
I don't think this is really worth my time honestly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215