Use url path for snapshot src attribute #270
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Problem
When running Cypress with Chromatic on Windows machines, the sourceMap object was storing Windows file system paths (containing backslashes) as values, which were then used to update the
src
attributes in the DOM snapshots.While the Windows file system path may work for an image url (browser normalize it automatically), but urls used in CSS properties could be broken and caused resource not found since backslashes are used for css escape. For example, this code:
can be interpreted as this:
What this PR does
Separate the concerns of file system operations and URL generation:
How to test