Report bytestring parsing errors in get as exceptions
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matus-chordify
force-pushed
the
report-parsing-errors
branch
2 times, most recently
from
e675327 to
ca6c0e9
Compare
Until now, bytestring parsing in `get` and friends would return `Nothing`, which is indistinguishable from the key not being present.
matus-chordify
force-pushed
the
report-parsing-errors
branch
from
ca6c0e9 to
eb334b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, bytestring parsing in
getand friends would returnNothing, which is indistinguishable from the key not being present. This is also inconsistent with other places wherefromBSis called, such as hash decoding, where the errors are reported properly.This patch adds proper exception throwing to
valGetas well.