Skip to content

Conversation

750
Copy link
Collaborator

@750 750 commented Nov 23, 2024

No description provided.

@chipsenkbeil
Copy link
Owner

@750 per your comment about some of the copy/paste properties being renamed by MacOS, is there any concern of this breaking actively when someone is using it? I don't really know what the renaming implies in terms of risk & maintenance.

@750
Copy link
Collaborator Author

750 commented Nov 23, 2024

@chipsenkbeil
(not sure i understodd your question correctly)

Whether it will break something for people already using choose: I doubt it.
Maybe there are people who for some reason use those very common shortcuts for something else - but that means that they already have them set to some other action, so no conflicts expected.
Relevant xkcd: https://xkcd.com/1172/

Here is some context:

  • While testing this PR I enabled showing menu bar - undo was shown as "Undo Typing" instead of just "Undo".
  • Option names are useful if one wants to remap something globally (like "Copy" in all applications to something other than cmd+c) or for a single app. I'm not sure whether the system renaming our option affects this feature - it probably does. If this is a problem for some people - lets wait for a bug report and then fix it

@chipsenkbeil
Copy link
Owner

Makes sense to me. Thanks! Merging now. Let me know when we want to cut a new release. You had 6 items in your QoL issue, and I think with this we're down to the last two?

@chipsenkbeil chipsenkbeil merged commit 8a85015 into chipsenkbeil:master Nov 23, 2024
@750
Copy link
Collaborator Author

750 commented Nov 23, 2024

here is a video of that (bug|weird behaviour)

Screen.Recording.2024-11-24.at.00.00.45.mov

@750
Copy link
Collaborator Author

750 commented Nov 23, 2024

@chipsenkbeil let's make a new release now - the last two features are not as important

@chipsenkbeil
Copy link
Owner

@chipsenkbeil let's make a new release now - the last two features are not as important

Release 1.4.0 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants