criu: Version 4.1.1 #2701
Merged
criu: Version 4.1.1 #2701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A kernel change (commit 12f147ddd6de, "do_change_type(): refuse to operate on unmounted/not ours mounts") modified how mount propagation properties can be changed. Previously, these properties could be changed from any mount namespace. Now, they can only be modified from the specific mount namespace where the target mount is actually mounted This commit addresses this new restriction by ensuring that CRIU enters the correct mount namespace before attempting to restore mount propagation properties (MS_SLAVE or MS_SHARED) for a mount. Signed-off-by: Andrei Vagin <[email protected]>
Fixes a clang compile-time error: "argument unused during compilation: '-c'". Signed-off-by: Andrei Vagin <[email protected]>
This release of CRIU (4.1.1) addresses a critical compatibility issue introduced in the Linux kernel and back-ported to all stable releases. The kernel commit (12f147ddd6de "do_change_type(): refuse to operate on unmounted/not ours mounts") addressed the security issue introduced almost 20 years ago. Unfortunately, this change inadvertently broke the restore functionality of mount namespaces within CRIU. Users attempting to restore a container on updated kernels would encounter the error: "mnt-v2: Failed to make mount 476 slave: Invalid argument." This release contains the necessary adjustments to CRIU, allowing it to work seamlessly with kernels incorporating this security change. Signed-off-by: Andrei Vagin <[email protected]>
adrianreber
approved these changes
Jul 29, 2025
mihalicyn
approved these changes
Jul 29, 2025
rst0git
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release of CRIU (4.1.1) addresses a critical compatibility issue introduced in the Linux kernel and back-ported to all stable releases.
The kernel commit (12f147ddd6de "do_change_type(): refuse to operate on unmounted/not ours mounts") addressed the security issue introduced almost 20 years ago. Unfortunately, this change inadvertently broke the restore functionality of mount namespaces within CRIU. Users attempting to restore a container on updated kernels would encounter the error: "mnt-v2: Failed to make mount 476 slave: Invalid argument."
This release contains the necessary adjustments to CRIU, allowing it to work seamlessly with kernels incorporating this security change.