Handling zoom edge cases (#690) #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounds Scale bounds may be stale if data/bounds are updated just before getInitialScaleBounds. Among other things, this could cause isZoomedOrPanned to be false after resetZoom. This does not address all cases where data/bounds are updated while the chart is zoomed or panned, though resetZoom now corrects this discrepancy.
Addresses at least two edge cases where minRange produced unintuitive effects: * When zooming in and the zoom range was close to both the min and max limits, minRange adjustment would produce jitter violating the max. * When zooming out against a limit, range was truncated such that a zoomout from the opposite side of the chart could no-op. However, this may have an undesirable implication for category axis zooming since zooming out against a limit can now alternate between zooming out by 1 or 2 categories whereas before it would tend to truncate to 1.
Closed
etimberg
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two commits fixing the following edge cases (see #690 for details and demos):
isZoomedOrPanned()true afterresetZoomif data changed while zoomedOne remaining concern is that this can affect zooming out from category scales in a potentially unintuitive way; further adjustments may be possible once we decide what the desired behavior is.
Thank you; let me know if you'd like any edits!