Skip to content

Remove Bower #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ custom/*

docs/index.md

bower.json
bower_components/

coverage/*

nbproject/*
Expand Down
5 changes: 2 additions & 3 deletions MAINTAINING.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@ Chart.js relies on [Travis CI](https://travis-ci.org/) to automate the library [
Merging into the `release` branch kicks off the automated release process:

* build of the `dist/*.js` files
* `dist/*.js` are copied to the root directory
* `bower.json` is generated from `package.json`
* `dist/*.js` and `bower.json` are added to a detached branch
* `dist/*.js` is copied to the root directory
* `dist/*.js` is added to a detached branch
* a tag is created from the `package.json` version
* tag (with dist files) is pushed to GitHub

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ Programmatically resets the zoom to the default state. See [samples/zoom-time.ht

To download a zip, go to the chartjs-plugin-zoom.js on Github

To install via npm / bower:
To install via npm:

```bash
npm install chartjs-plugin-zoom --save
Expand Down
19 changes: 0 additions & 19 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ function run(bin, args, done) {
ps.on('close', () => done());
}

gulp.task('bower', bowerTask);
gulp.task('build', gulp.series(rollupTask, copyDistFilesTask));
gulp.task('package', packageTask);
gulp.task('bump', bumpTask);
Expand All @@ -46,24 +45,6 @@ gulp.task('test', gulp.parallel('lint', 'unittest'));
gulp.task('watch', watchTask);
gulp.task('default', gulp.parallel('lint', 'build', 'watch'));

/**
* Generates the bower.json manifest file which will be pushed along release tags.
* Specs: https://github.com/bower/spec/blob/master/json.md
*/
function bowerTask() {
var json = JSON.stringify({
name: pkg.name,
description: pkg.description,
homepage: pkg.homepage,
license: pkg.license,
version: pkg.version,
main: outDir + pkg.name + '.js'
}, null, 2);

return file('bower.json', json, {src: true})
.pipe(gulp.dest('./'));
}

function rollupTask(done) {
run('rollup/dist/bin/rollup', ['-c'], done);
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ git remote add auth-origin https://[email protected]/$TRAVIS_REPO_SL
git config --global user.email "$GITHUB_AUTH_EMAIL"
git config --global user.name "Chart.js"
git checkout --detach --quiet
git add -f dist/*.js bower.json
git add -f dist/*.js
git commit -m "Release $VERSION"
git tag -a "v$VERSION" -m "Version $VERSION"
git push -q auth-origin refs/tags/v$VERSION 2>/dev/null
Expand Down