Category zoom #39
Category zoom #39
Conversation
|
This works quite well 😄 The last commit says 'change indents to match github' but I get a ton of diffs. Is that intended? |
| } | ||
| zoomNS.zoomCumulativeDelta = 0; | ||
| } | ||
| if(zoomNS.zoomCumulativeDelta > 0){ |
There was a problem hiding this comment.
Minor point:
I think this should be else if (zoomNS.zoomCumulativeDelta > 0) unless I've missed a way that the cumulative delta can become negative in the first block
There was a problem hiding this comment.
You are correct!
|
|
||
| if (Math.abs(zoomNS.zoomCumulativeDelta) > sensitivity){ | ||
| if(zoomNS.zoomCumulativeDelta < 0){ | ||
| if(center.x <= scale.width/2){ |
There was a problem hiding this comment.
I don't think this check is entirely correct. It only works if scale.left === 0.
I think it would be better as
if (center.x <= scale.left + (scale.width / 2))
There was a problem hiding this comment.
Also, since this is used 4 times, it helps for minification if we store it in a variable at the top of the function
There was a problem hiding this comment.
Another thought is that checking the x only works if the scale is horizontal. scale.isHorizontal() returns true if this case is met. This should be updated to work for vertical index scales such as those that can occur in a horizontal bar chart.
There was a problem hiding this comment.
I was trying to not leave a dead zone when the pointer/pinch centre was at dead center as the other check is just for greater than.
Hadn't thought about minification, but I will now!
I'll fix the isHorizontal issue too
The indents are still bugging me too but I didn't have time to sort then out. Next commit will hopefully. Do you prefer tab or space indents?
| } else{ | ||
| minIndex = Math.max(0, minIndex - 1); | ||
| } | ||
| } else if(center.x > scale.width/2){ |
| zoomNS.zoomCumulativeDelta = 0; | ||
| } | ||
| if(zoomNS.zoomCumulativeDelta > 0){ | ||
| if(center.x <= scale.width/2){ |
| if(zoomNS.zoomCumulativeDelta > 0){ | ||
| if(center.x <= scale.width/2){ | ||
| minIndex = minIndex < maxIndex ? minIndex = Math.min(maxIndex, minIndex + 1) : minIndex; | ||
| } else if(center.x > scale.width/2){ |
|
Internet access is awful here at the moment. Will get it done asaic |
|
Awesome! Per your tabs and spaces question, i prefer tabs |
Indents need to be checked
Hi,
I've got the category zooming to work.
Added an option under zoom to change how fast it zooms called sensitivity (we can rename if you like!)
Added a check that options.sensitivity exists or uses default.
Had to use another global under the zoomNS namespace called zoomCumulativeDelta.
Zooms from left or right then fills out the other side.
New sample added, but we could just use the existing zoom-bar or rename if you want.
Thanks
Rob