-
Notifications
You must be signed in to change notification settings - Fork 365
Update packaging to match main chart.js library #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, but donwe really want to rename the umd files?
@kurkle I wen back to the original version, without using UMD in the dist files, as shared. Let me know if it's ok and if yes, let me know if you think we should publish new version 2.1.1 (bumping). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except it won't work in node/commonjs.
@etimberg is it ok for you to drop cjs support for plugins too? (main repo already did)
package.json
Outdated
"main": "dist/chartjs-plugin-annotation.js", | ||
"module": "dist/chartjs-plugin-annotation.esm.js", | ||
"type": "module", | ||
"main": "dist/chartjs-plugin-annotation.esm.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to support chart.js v3 on node/commonjs with these later annotation plugin versions, this needs to be umd build with .cjs extension
Something like I did in autocolors: https://github.com/kurkle/chartjs-plugin-autocolors/blob/main/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok Let me update in next hours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kurkle updated as suggested
Dropping is fine by me, but should definitely be a major version release |
@etimberg ok that means all plugins/controllers in chartjs org must publish a major version for chartjs 4 compatibility, doesn’t it? |
I don't think it's mandatory if the plugin packaging doesn't change |
There could be some benefits to from |
Fix #814