Skip to content

Reduce complexity for resolving the label callout position #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2022
Merged

Reduce complexity for resolving the label callout position #743

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a251214
Reduce complexity for resolving the label callout position
stockiNail May 20, 2022
d834df4
fixes lint
stockiNail May 20, 2022
80a3359
uses includes instead of indexOf
stockiNail May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/types/label.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ function getCalloutSideAdjust(position, options) {

function resolveCalloutPosition(element, options) {
const position = options.position;
if (position === 'left' || position === 'right' || position === 'top' || position === 'bottom') {
if (positions.indexOf(position) >= 0) {
return position;
}
return resolveCalloutAutoPosition(element, options);
Expand Down