Docs/clarify usage of ticks callback (#9991) #9994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
previously approved these changes
Dec 15, 2021
etimberg
reviewed
Dec 15, 2021
| Keep in mind that overriding `ticks.callback` means that you are responsible for all formatting of the label. Depending on your use case, you may want to call the default formatter and then modify its output. In the example above, that would look like: | ||
|
|
||
| ```javascript | ||
| // call the default formatter, forwarding `this` |
Member
There was a problem hiding this comment.
It looks like there's some leading whitespace here which could be removed
Contributor
Author
There was a problem hiding this comment.
I kept the leading whitespace the same as in the example above, to emphasize that the snippet would substitute for return '$' + value;.
LeeLenaleee
requested changes
Dec 15, 2021
kurkle
approved these changes
Dec 16, 2021
LeeLenaleee
approved these changes
Dec 16, 2021
etimberg
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #9991, this clarifies the responsibilities of ticks callback functions and adds an example.