-
Notifications
You must be signed in to change notification settings - Fork 196
feat(accessibility): prompt improvements #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 14 out of 16 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- examples/go.mod: Language not supported
- go.mod: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (2)
- examples/go.mod: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
field_multiselect.go:728
- In the multi-select accessible mode, when a user selects 0 to confirm selection and the validation passes, the loop fails to exit, resulting in an infinite loop. Add a break statement after successful validation inside the if(choice == 0) block.
if choice == 0 {
*: Realistically, we can only either enable or disable echo, and to do that, the input needs to be a terminal.
example usage:
closes #619