Skip to content

fix(select,multiselect): multi line items, scrolling #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 11, 2025
Merged

fix(select,multiselect): multi line items, scrolling #569

merged 4 commits into from
Mar 11, 2025

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Mar 11, 2025 •
edited
Loading

  • properly render multi line items by using lipgloss.JoinHorizontal
  • properly handle scrolling when an item has multiple lines
  • added tests

closes #429

Before

CleanShot 2025-03-11 at 14 36 06

CleanShot_2025-03-11_at_14.40.10.mov

After

CleanShot 2025-03-11 at 14 34 11

CleanShot_2025-03-11_at_14.51.37.mov

@caarlos0 caarlos0 added bug Something isn't working select multiselect labels Mar 11, 2025
@caarlos0 caarlos0 self-assigned this Mar 11, 2025
@caarlos0 caarlos0 requested a review from a team as a code owner March 11, 2025 18:14
@caarlos0 caarlos0 requested review from raphamorim and removed request for a team March 11, 2025 18:14
@caarlos0 caarlos0 merged commit 9f09390 into main Mar 11, 2025
42 checks passed
@caarlos0 caarlos0 deleted the select branch March 11, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas aymanbagabas approved these changes

@raphamorim raphamorim Awaiting requested review from raphamorim raphamorim is a code owner automatically assigned from charmbracelet/everyone

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working multiselect select
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select options disappear when other options wrap
2 participants
@caarlos0 @aymanbagabas