Unified error code #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tiny.x <[email protected]>
Signed-off-by: tiny.x <[email protected]>
… errno from old number to new number. 3. add log
… errno from old number to new number. 3. add log
# Conflicts: # Makefile # exec/bin/dropnetwork/dropnetwork.go # go.sum
… return code and error message
xcaspar
approved these changes
Apr 7, 2021
xcaspar
added a commit
that referenced
this pull request
Apr 7, 2021
* fixbug: Under some systems, processes cannot exit using kill -HUP Signed-off-by: tiny.x <[email protected]> * chore: update version to 0.9.0 Signed-off-by: tiny.x <[email protected]> * unify errno: 1. add check cmd exist or not before exec cmd. 2. change errno from old number to new number. 3. add log * fix bug: return response use new error no,and add log * unify errno: 1. add check cmd exist or not before exec cmd. 2. change errno from old number to new number. 3. add log * edit "ChannelNil" and "OsCmdExecFailed" response, delete result, only return code and error message Co-authored-by: tiny.x <[email protected]> Co-authored-by: camix <[email protected]> Co-authored-by: xcaspar <[email protected]>
tiny-x
added a commit
that referenced
this pull request
May 31, 2021
* fixbug: Under some systems, processes cannot exit using kill -HUP Signed-off-by: tiny.x <[email protected]> * chore: update version to 0.9.0 Signed-off-by: tiny.x <[email protected]> * unify errno: 1. add check cmd exist or not before exec cmd. 2. change errno from old number to new number. 3. add log * fix bug: return response use new error no,and add log * unify errno: 1. add check cmd exist or not before exec cmd. 2. change errno from old number to new number. 3. add log * edit "ChannelNil" and "OsCmdExecFailed" response, delete result, only return code and error message Co-authored-by: tiny.x <[email protected]> Co-authored-by: camix <[email protected]> Co-authored-by: xcaspar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
At present, the error codes of the replies are messy, which requires unified and refactoring.
Does this pull request fix one issue?
Fixes chaosblade-io/chaosblade#489
Describe how you did it
Unified error code structure and error content