fix: Change the value pass in slope to a reference pass. #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Super-long <[email protected]>
tiny-x
approved these changes
Jun 14, 2022
hengyoush
pushed a commit
to hengyoush/chaosblade-exec-os
that referenced
this pull request
May 15, 2023
…io#116) Signed-off-by: Super-long <[email protected]> Co-authored-by: tiny-x <[email protected]> Signed-off-by: hengyoush <[email protected]>
hengyoush
pushed a commit
to hengyoush/chaosblade-exec-os
that referenced
this pull request
May 15, 2023
…io#116) Signed-off-by: Super-long <[email protected]> Co-authored-by: tiny-x <[email protected]> Signed-off-by: hengyoush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Super-long [email protected]
Describe what this PR does / why we need it
Currently, the slopePercent parameter in slope is passed as a value, and changes to slopePercent cannot be passed outside of slope, so this bug prevents
-climb-timefrom taking effect.Describe how you did it
Change the value pass in slope to a reference pass.