-
Notifications
You must be signed in to change notification settings - Fork 149
Start of exhaustively documenting the build file. #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ville Aikas <[email protected]>
There are bunch of TODO(vaikas) that I need some help with, so just jotted them down while I was writing. I'll keep iterating. |
docs/BUILD-FILE.md
Outdated
# melange build file | ||
|
||
This documents the melange build file structure, fields, when, and why to use | ||
various fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other folks might disagree, but IMO one line per sentence in markdown makes diffs a lot nicer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you seriously suggesting on not wrapping at 80???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonjohnsonjr my bad for disagreeing but as someone who spends a lot of time comparing markdown files I appreciate the wrapping 😬
docs/BUILD-FILE.md
Outdated
|
||
Ordered list of pipelines that produce this package | ||
|
||
And the following optional sections: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd have required and optional section headings as ##
and unindent these bullet points (or make them ###
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, I'm not so good with markdown.
Signed-off-by: Ville Aikas <[email protected]>
Addressed feeback, and I added some great verbiage from @erikaheidi here. |
1 similar comment
Addressed feeback, and I added some great verbiage from @erikaheidi here. |
While learning about, couldn't really find one place to understand the build file, fields, etc. so figured I'd take a crack at creating one. Not comprehensive, but a start to see if keeping on going makes sense.