Skip to content

Start of exhaustively documenting the build file. #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

vaikas
Copy link
Member

@vaikas vaikas commented Aug 17, 2023

While learning about, couldn't really find one place to understand the build file, fields, etc. so figured I'd take a crack at creating one. Not comprehensive, but a start to see if keeping on going makes sense.

@vaikas vaikas requested a review from a team as a code owner August 17, 2023 01:51
@vaikas vaikas requested review from jonjohnsonjr and removed request for a team August 17, 2023 01:51
@vaikas
Copy link
Member Author

vaikas commented Aug 17, 2023

There are bunch of TODO(vaikas) that I need some help with, so just jotted them down while I was writing. I'll keep iterating.

# melange build file

This documents the melange build file structure, fields, when, and why to use
various fields.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other folks might disagree, but IMO one line per sentence in markdown makes diffs a lot nicer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you seriously suggesting on not wrapping at 80???

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonjohnsonjr my bad for disagreeing but as someone who spends a lot of time comparing markdown files I appreciate the wrapping 😬


Ordered list of pipelines that produce this package

And the following optional sections:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have required and optional section headings as ## and unindent these bullet points (or make them ###).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, I'm not so good with markdown.

@vaikas
Copy link
Member Author

vaikas commented Aug 18, 2023

Addressed feeback, and I added some great verbiage from @erikaheidi here.

1 similar comment
@vaikas
Copy link
Member Author

vaikas commented Aug 18, 2023

Addressed feeback, and I added some great verbiage from @erikaheidi here.

@vaikas vaikas merged commit ec726bf into chainguard-dev:main Aug 31, 2023
@vaikas vaikas deleted the document-build-file branch August 31, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants