Refactor the config/logging stuff out of build #581
Conversation
This is the preliminary part of work to refactor renovate to allow it to use var transforms and other future config infrastructure. Signed-off-by: Elizabeth Myers <[email protected]>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.2+incompatible to 24.0.5+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v24.0.2...v24.0.5) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
|
Looks like some solid work! Tests need to be fixed up, obviously, and once those are fixed, the linter should be happy too. The integration tests appear OK. |
On that. The big issue I'm having right now is trying to figure out how to sort the build test from the config test. They're sort of joined at the hip at the moment (to be fair, Build is a major consumer of the API). Most of the tests in pkg/build/build_test.go look like config tests at first glance, but also use |
Elizafox
force-pushed
the
main
branch
3 times, most recently
from
04bcc2c to
85cf4ae
Compare
Signed-off-by: Elizabeth Myers <[email protected]>
Signed-off-by: Elizabeth Myers <[email protected]>
Signed-off-by: Elizabeth Myers <[email protected]>
|
Sorry about the noise. I messed up my git history (forgot to sign commits and signoff a commit). Git is not a very user-friendly tool when you have to amend history. :( |
I just decided to edit the existing tests and go with that for now. They also happen to test the config. |
Signed-off-by: Elizabeth Myers <[email protected]>
This is the preliminary part of work to refactor renovate to allow it to use var transforms and other future config infrastructure.