scan: Return an error instead of os.Exit(1) #2065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We defer a bunch of Close() calls to clean up temporary directories, but defers aren't executed if you call os.Exit, so these were leaking when using the --diff flag. Instead, just return an error, which will still exit with an error code of 1, but only after running the clean up defers. Signed-off-by: Jon Johnson <[email protected]>
murraybd
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We defer a bunch of Close() calls to clean up temporary directories, but defers aren't executed if you call os.Exit, so these were leaking when using the --diff flag.
Instead, just return an error, which will still exit with an error code of 1, but only after running the clean up defers.