-
Notifications
You must be signed in to change notification settings - Fork 146
feat: add SLSA provenance generation for package builds #2051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the code in any detail, but I know we have at least one test that makes assumptions about the contents of packages:
https://github.com/wolfi-dev/os/blob/main/pipelines/test/docs.yaml#L21
We should probably add a pipeline-utils
package to tw
that has a tw-list-apk-contents
command that hides sbom/provenance (with maybe a --show-melange-generated
to unhide them)
Ack. The new file lives next to |
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
This is now a non-issue with the changes in Storing the provenance alongside artifacts in this manner is called out by SLSA as well. |
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: Evan Gibler <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: Evan Gibler <[email protected]>
So this is looking good, I'm +1 on getting this merged. However: I'm a bit worried about all the failing tests. The Can you see what's that about? If it's unrelated, can you make sure that all the tests are run and there are actually no failures? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I actually see this failure on my PR as well. Approving this, but please make sure the tests are passing (at least locally) before pressing merge! Thanks!
This PR adds opt-in SLSA provenance generation for package builds and is consistent with what we've implemented elsewhere.
By default, we're leaving this off while we land on the final structure. That said, CI will use the new flag (
--generate-provenance
) to validate changes and, of course, local builds can also use this.The resulting provenance statement is stored in a separate
.attest.tar.gz
file and is signed in the same way as the APK. This new tarball contains the.attestation
file for the package and the public signing key.