Skip to content

Delete named pipes instead of broadly excluding fifo files #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

egibs
Copy link
Member

@egibs egibs commented Jun 10, 2025

We're currently excluding fifo files by name which is preventing certain legitimate files and directories that are needed in the emitted APK.

This PR deletes any named pipe files before we try to archive the workspace instead of potentially excluding valid directories or files.

@egibs egibs requested a review from 89luca89 June 10, 2025 21:05
Signed-off-by: egibs <[email protected]>
Copy link
Member

@stevebeattie stevebeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that both dpkg (the original reason for excluding fifos) and grafana-image-renderer build and test correctly, excluding files of type fifo without excluding files with fifo in their names.

@egibs egibs enabled auto-merge (squash) June 10, 2025 21:30
@egibs egibs merged commit f203105 into chainguard-dev:main Jun 10, 2025
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants