-
Notifications
You must be signed in to change notification settings - Fork 146
SBOM: add a OperatingSystem package to each apk SBOM #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
Created this PR to export the ParseReleaseData chainguard-dev/apko#1721 . Once it's merged, I'll modify the code here and re-submit for review :) |
Approved! Let me refactor the code and make everything shiny again. |
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better now, thanks @sil2100!
Some tests are failing which is blocking the merge, but I think it's just a matter of adjusting expected outputs.
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
One of the failures demonstrated an actual situation that needed handling. Now it should look better! |
Hm, some tests are still failing :-(. |
I think those are unrelated. If you take a look at the failures, they fail due to |
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @sil2100 !
Some CVE scanners, like trivy, might print warnings if OperatingSystem is not defined. Let's define it. But for this, we need access to the os-release file that's on the builder.
No real tests added as I couldn't think of a nice way of testing the runner code.