Skip to content

test(e2e/pipelines): run tests on qemu runner #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025

Conversation

maxgio92
Copy link
Contributor

@maxgio92 maxgio92 commented May 21, 2025

This PR sets the QEMU runner as the default runner for e2e tests for pipelines.
It uses the Alpine kernel, the same way we do for the Wolfi presubmit CI workflow.

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

@maxgio92 maxgio92 force-pushed the e2e-tests-pipelines-on-qemu branch from 6f1d7bf to 9fa6cb6 Compare May 21, 2025 16:02
@maxgio92 maxgio92 force-pushed the e2e-tests-pipelines-on-qemu branch from 9fa6cb6 to 4c8b749 Compare May 21, 2025 17:37
@maxgio92 maxgio92 changed the title wip(e2e-tests): run pipeline e2e tests on qemu runner wip(e2e-tests): run e2e tests on qemu runner May 21, 2025
@maxgio92 maxgio92 changed the title wip(e2e-tests): run e2e tests on qemu runner test(e2e): run e2e tests on qemu runner May 21, 2025
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
@maxgio92 maxgio92 changed the title test(e2e): run e2e tests on qemu runner test(e2e/pipelines): run e2e tests on qemu runner May 21, 2025
@maxgio92 maxgio92 changed the title test(e2e/pipelines): run e2e tests on qemu runner test(e2e/pipelines): run tests on qemu runner May 21, 2025
@maxgio92 maxgio92 marked this pull request as ready for review May 21, 2025 21:59
@maxgio92 maxgio92 enabled auto-merge (squash) May 22, 2025 13:12
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
@maxgio92
Copy link
Contributor Author

I think we need force merge in this case, since test failures are not related to the changes, but CVEs found on fixture packages.
cc @chainguard-dev/tools-squad

@dannf
Copy link
Contributor

dannf commented Jun 10, 2025

I didn't know we used the alpine kernel there - seems like we should allow that in the wolfi-dev/os Makefile then, w/ possibly an environment variable to override to use the CG one?

@maxgio92
Copy link
Contributor Author

@dannf I'm not against it. I would like to have approval from @chainguard-dev/sustaining-team for managing it.
In the meantime, I would unlock this PR if possible and manage it in a separated one to introduce the alpine kernel package and make Melange CI to use it. WDYT?

@maxgio92 maxgio92 merged commit ece051e into chainguard-dev:main Jun 17, 2025
88 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants