usrmerge: lint for lib64 usage #1927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib64 has always been a symlink to lib in wolfi. However file installation has been soft allowed into that location. As it sort of worked if wolfi-baselayout is unpacked first. But it still leads to `apk audit` failing. As we are getting more strict with file locations in the .apks, add /lib64 and /usr/lib64 linting. At this time one should use /lib and /usr/lib locations instead.
|
glibc is now merged; and should rebuild as green. but also need to run analysis on /lib64 usage. |
|
gitsign & guac => it's just CVE flag up, the build is successful. |
a-crate
reviewed
Apr 17, 2025
| @@ -811,6 +812,12 @@ func usrmergeLinter(ctx context.Context, _ *config.Configuration, _ string, fsys | |||
| if strings.HasPrefix(path, "usr/sbin") { | |||
| return fmt.Errorf("package writes to /usr/sbin in violation of usrmerge: %s", path) | |||
| } | |||
| if strings.HasPrefix(path, "lib64") { | |||
There was a problem hiding this comment.
This can be refactored to for _, symlink := range symlinked; [...] now
smoser
previously approved these changes
Apr 17, 2025
There was a problem hiding this comment.
As of "right now" usr/lib64 has offenders in
| repo | origin | binpkg |
|---|---|---|
| wolfi | apache-orc | apache-orc |
| wolfi | apache-orc | apache-orc-dev |
| wolfi | fontforge | fontforge |
| wolfi | libffi | libffi |
| wolfi | libffi | libffi-dev |
| wolfi | libffi | libffi-pic-dev |
| wolfi | mimalloc2 | mimalloc2 |
| wolfi | mimalloc2 | mimalloc2-dev |
| wolfi | mold | mold |
| extras | msodbcsql18 | msodbcsql18 |
| wolfi | sysstat | sysstat |
| wolfi | xfsprogs | xfsprogs-dev |
| wolfi | xfsprogs | xfsprogs-libs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib64 has always been a symlink to lib in wolfi. However file
installation has been soft allowed into that location. As it sort of
worked if wolfi-baselayout is unpacked first. But it still leads to
apk auditfailing. As we are getting more strict with file locationsin the .apks, add /lib64 and /usr/lib64 linting.
At this time one should use /lib and /usr/lib locations instead.