linter:usrmerge: Improve error message to list files

[justinvreeland]

Looks like this:

Package contains paths in violation of usrmerge:
bin
bin/test
sbin
sbin/test
usr/sbin
usr/sbin/test

[smoser]

I think the code on lines 803-810 is effectively unreachable . unless WalkDir searches depth-first.

But this is better than it was.

I would prefer a list of the things that are bad. But Justin says this is better.

[justinvreeland]

Most of our other linters exit on the first error they find and I don't see a benefit to listing the files beyond the first one you encounter since the remedy is the same. I'll check if that's unreachable and probably remove that section if it is.

[justinvreeland]

need to remove the schema updates and such that snuck in. idk why these aren't update in the pr that should've changed them.

[smoser]

i think this looks fine. the only question, from reading this I think that the commit message is out dated.

you would not see directories listed, right? only non-directories. Ie, in the following no usr/sbin or bin or usr/sbin in the beolow.

Package contains paths in violation of usrmerge:
bin
bin/test
sbin
sbin/test
usr/sbin
usr/sbin/test

[justinvreeland]

i think this looks fine. the only question, from reading this I think that the commit message is out dated.

Ahh yeah I need to update that or fix it in the merge command.

in the following no usr/sbin or bin or usr/sbin in the beolow.

Every other line is a directory in that snippet?

[justinvreeland]

Oh of course I updated the commit message not the github summary dislike