Skip to content

Updating install script and Dockerfile to use version ARG #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

erikaheidi
Copy link
Collaborator

This updates the server install to check for a default value of "latest", and updates the Dockerfile to use an ARG to set the server version. You can now specify the server version at build time:

docker build --build-arg VERSION=1.21.4 . -t guardcraft-1.21.4

@erikaheidi erikaheidi requested a review from Copilot March 20, 2025 17:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the installation instructions and Docker build process to support specifying the server version at build time.

  • Updated usage instructions in the README to mention the build argument for setting the server version.
  • Provided a Docker build command example showing the use of the build argument.
Files not reviewed (2)
  • Dockerfile: Language not supported
  • server-install.sh: Language not supported
Comments suppressed due to low confidence (1)

README.md:45

  • The version mentioned in the client connection instructions (1.21.5 Pre-Release 3) does not match the version shown in the build command (1.21.4). Consider using a consistent version across the documentation.
Please note the client must be running the same version of the server software (in this case, `1.21.5 Pre-Release 3`)

@erikaheidi erikaheidi merged commit 16255ef into chainguard-dev:main Mar 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant