Skip to content

Conversation

flacoman91
Copy link
Contributor

@flacoman91 flacoman91 commented Aug 14, 2025

Addresses: DATAP-897

  • Updated build script to copy font file from node_modules
  • Consolidate flaky cypress filter test due to it failing constantly in CI (but not locally) 🤔
  • Consolidate other cypress tests to take advantage of RTK Query caching to make testing faster
  • Removes create react app in favor of rsbuild
  • browserslist-rs currently doesn't support queries, so we are just using the standard rules. link. Once this is supported we will switch to use cfpb shared configs.

To test:
delete node_modules

yarn commands should still work

yarn install;
yarn test;
yarn build;
yarn start

@flacoman91 flacoman91 marked this pull request as draft August 14, 2025 04:06
@flacoman91 flacoman91 force-pushed the DATAP-897-cra-to-rsbuild-migration branch from 80e9bed to 1b224e2 Compare August 15, 2025 17:26
adding correct ignore rules

remove craco and craco esbuild

adding svg config options

more better test updates

fixing up tests

update list consolelog

add option to disable prefix ids and classnames

remove .only

update build output options

update output build file name

revert

remove custom browserslist in package.json

restore plugin

remove unnecessary lib

update output folder of fonts

update dist, build font path

adding eslint rule to deprecate and clean up old jest test

updating cypress override eslint
@flacoman91 flacoman91 force-pushed the DATAP-897-cra-to-rsbuild-migration branch from e4619ee to 4675877 Compare August 18, 2025 20:00
@flacoman91 flacoman91 marked this pull request as ready for review August 18, 2025 22:33
@flacoman91 flacoman91 requested a review from higs4281 August 18, 2025 23:21
@flacoman91 flacoman91 mentioned this pull request Aug 18, 2025
9 tasks
Copy link
Member

@higs4281 higs4281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After getting node 24 running locally, I could run all the suggested yarn commands except for yarn serve, which did nothing. However yarn start did work, and fired up a ccdb instance at port 3000.

@flacoman91
Copy link
Contributor Author

After getting node 24 running locally, I could run all the suggested yarn commands except for yarn serve, which did nothing. However yarn start did work, and fired up a ccdb instance at port 3000.

Whoops, you are correct, I meant yarn start

@flacoman91 flacoman91 added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 411d8fa Sep 2, 2025
1 check passed
@flacoman91 flacoman91 deleted the DATAP-897-cra-to-rsbuild-migration branch September 2, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants