Skip to content

Conversation

Copy link

Copilot AI commented Sep 30, 2025

(I've edited Copilot's PR description as I found it way to verbose)

I found a couple of useful links can be found via the project icons at https://contribute.cncf.io/contributors/projects/:

#cert-manager: https://kubernetes.slack.com/messages/cert-manager
#cert-manager-dev: https://kubernetes.slack.com/messages/cert-manager-dev

I propose to add these links so that folks can directly jump to the correct channel once they joined the invite link (https://slack.k8s.io/).

@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 30, 2025
@cert-manager-prow cert-manager-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2025
@netlify
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for cert-manager ready!

Name Link
🔨 Latest commit 6eaa488
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/68db8c1988cffb00082e699b
😎 Deploy Preview https://deploy-preview-1787--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maelvls. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI changed the title [WIP] Update Slack channel links in releases README to direct channel URLs Update Slack links to use direct channel URLs instead of generic invite Sep 30, 2025
Copilot AI requested a review from maelvls September 30, 2025 06:46
Copilot finished work on behalf of maelvls September 30, 2025 06:46
@maelvls
Copy link
Member

maelvls commented Sep 30, 2025

@copilot I was a bit off. https://slack.k8s.io/ is a great link for joining the Kubernetes Slack. The two links I found won't allow you to join it, but they will allow you to open the Slack channels if you already are registered to the Kubernetes Slack. Make the change in the PR.

Copy link
Author

Copilot AI commented Sep 30, 2025

@copilot I was a bit off. https://slack.k8s.io/ is a great link for joining the Kubernetes Slack. The two links I found won't allow you to join it, but they will allow you to open the Slack channels i...

Updated in commit 57df72d. The text now includes both the invite link (https://slack.k8s.io/) for joining Kubernetes Slack and the direct channel links for accessing the specific channels once registered.

The Technical Support section now reads: "You can request support from the community on Kubernetes Slack (in the #cert-manager or #cert-manager-dev channels)"

Copilot AI changed the title Update Slack links to use direct channel URLs instead of generic invite Update Slack links to include both invite and direct channel URLs Sep 30, 2025
Copilot finished work on behalf of maelvls September 30, 2025 06:56
@maelvls
Copy link
Member

maelvls commented Sep 30, 2025

@copilot Fix the DCO problem. You can use my own DCO line:

Signed-off-by: Maël Valais <[email protected]>

Copy link
Author

Copilot AI commented Sep 30, 2025

@copilot Fix the DCO problem. You can use my own DCO line:

...

I'm unable to retroactively add DCO sign-offs to the existing commits since I don't have access to git rebase or commit amend operations. The three commits (56d74b5, 44b44f8, 57df72d) would need to have their commit messages amended to include:

Signed-off-by: Maël Valais <[email protected]>

You can fix this by running:

git rebase --signoff HEAD~3
git push --force-with-lease

Alternatively, if you'd prefer, I can create a new commit with proper DCO that you can then squash with the previous commits.

Copilot finished work on behalf of maelvls September 30, 2025 07:07
@maelvls maelvls force-pushed the copilot/fix-e8391af4-4814-4439-ad18-d8b644d48e38 branch from 57df72d to a3b25cf Compare September 30, 2025 07:47
@maelvls maelvls force-pushed the copilot/fix-e8391af4-4814-4439-ad18-d8b644d48e38 branch from a3b25cf to 6eaa488 Compare September 30, 2025 07:51
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 30, 2025
@maelvls maelvls marked this pull request as ready for review September 30, 2025 07:52
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
Technical assistance is offered on a best-effort basis for supported
releases only. You can request support from the community on [Kubernetes
Slack](https://slack.k8s.io/) (in the `#cert-manager` channel), using
Slack](https://slack.k8s.io/) (in the [`#cert-manager`](https://kubernetes.slack.com/messages/cert-manager) or [`#cert-manager-dev`](https://kubernetes.slack.com/messages/cert-manager-dev) channels), using
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want people asking general support questions in cert-manager-dev. I think cert-manager-dev should be reserved for development discussions. Listing them both here will encourage people to cross-post to both channels.

Technical assistance is offered on a best-effort basis for supported
releases only. You can request support from the community on [Kubernetes
Slack](https://slack.k8s.io/) (in the `#cert-manager` channel), using
Slack](https://slack.k8s.io/) (in the [`#cert-manager`](https://kubernetes.slack.com/messages/cert-manager) or [`#cert-manager-dev`](https://kubernetes.slack.com/messages/cert-manager-dev) channels), using
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the 1.15 docs seems a bit random. Revert this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants