-
Notifications
You must be signed in to change notification settings - Fork 373
Update Slack links to include both invite and direct channel URLs #1787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cert-manager ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@copilot I was a bit off. https://slack.k8s.io/ is a great link for joining the Kubernetes Slack. The two links I found won't allow you to join it, but they will allow you to open the Slack channels if you already are registered to the Kubernetes Slack. Make the change in the PR. |
Updated in commit 57df72d. The text now includes both the invite link (https://slack.k8s.io/) for joining Kubernetes Slack and the direct channel links for accessing the specific channels once registered. The Technical Support section now reads: "You can request support from the community on Kubernetes Slack (in the |
|
@copilot Fix the DCO problem. You can use my own DCO line: |
... I'm unable to retroactively add DCO sign-offs to the existing commits since I don't have access to git rebase or commit amend operations. The three commits (56d74b5, 44b44f8, 57df72d) would need to have their commit messages amended to include: You can fix this by running: git rebase --signoff HEAD~3
git push --force-with-leaseAlternatively, if you'd prefer, I can create a new commit with proper DCO that you can then squash with the previous commits. |
57df72d to
a3b25cf
Compare
Signed-off-by: Maël Valais <[email protected]>
a3b25cf to
6eaa488
Compare
| Technical assistance is offered on a best-effort basis for supported | ||
| releases only. You can request support from the community on [Kubernetes | ||
| Slack](https://slack.k8s.io/) (in the `#cert-manager` channel), using | ||
| Slack](https://slack.k8s.io/) (in the [`#cert-manager`](https://kubernetes.slack.com/messages/cert-manager) or [`#cert-manager-dev`](https://kubernetes.slack.com/messages/cert-manager-dev) channels), using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want people asking general support questions in cert-manager-dev. I think cert-manager-dev should be reserved for development discussions. Listing them both here will encourage people to cross-post to both channels.
| Technical assistance is offered on a best-effort basis for supported | ||
| releases only. You can request support from the community on [Kubernetes | ||
| Slack](https://slack.k8s.io/) (in the `#cert-manager` channel), using | ||
| Slack](https://slack.k8s.io/) (in the [`#cert-manager`](https://kubernetes.slack.com/messages/cert-manager) or [`#cert-manager-dev`](https://kubernetes.slack.com/messages/cert-manager-dev) channels), using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the 1.15 docs seems a bit random. Revert this.
(I've edited Copilot's PR description as I found it way to verbose)
I found a couple of useful links can be found via the project icons at https://contribute.cncf.io/contributors/projects/:
#cert-manager: https://kubernetes.slack.com/messages/cert-manager
#cert-manager-dev: https://kubernetes.slack.com/messages/cert-manager-dev
I propose to add these links so that folks can directly jump to the correct channel once they joined the invite link (https://slack.k8s.io/).