-
Notifications
You must be signed in to change notification settings - Fork 373
Update issuer.md #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update issuer.md #1640
Conversation
Adds a note for a frequently encountered issue that will prevent users from being able to use a ClusterIssuer as suggested in the documentation. Solution comes from this issue comment: cert-manager/cert-manager#3246 (comment) Signed-off-by: Tobias Cohen <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello @tobico, thank you for contributing an enhancement to our documentation. I struggled to actually find the page when reviewing but finally found it. I have a couple of suggestions, but let me just suggest an alternate wording: When cert-manager is installed using Helm, the CRDs are not included by default.
Please refer to our [helm installation instructions](../installation/helm.md#2-install-cert-manager)
for the correct input value to enable the CRDs during installation.Mainly this was to:
If you are happy to update with something similar to above that'd be great. If not I can always make the change if you don't have time. |
|
|
||
| Note that when cert-manager is installed using Helm, the CRDs for the ClusterIssuer | ||
| resource type are not included by default. They can be included by adding the flag | ||
| `--set installCRDs=true` during installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `--set installCRDs=true` during installation. | |
| `--set crds.enabled=true` during installation. |
| Note that when cert-manager is installed using Helm, the CRDs for the ClusterIssuer | ||
| resource type are not included by default. They can be included by adding the flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Note that when cert-manager is installed using Helm, the CRDs for the ClusterIssuer | |
| resource type are not included by default. They can be included by adding the flag | |
| Note that when cert-manager is installed using Helm, the CRDs are not included by default. | |
| They can be included by adding the flag |
The CRD for Issuer is also not installed.
Adds a note for a frequently encountered issue that will prevent users from being able to use a ClusterIssuer as suggested in the documentation.
Solution comes from this issue comment: cert-manager/cert-manager#3246 (comment)