Skip to content

Bump sidecar images in preparation for release #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Jun 26, 2025

Same as cert-manager/csi-driver-spiffe#305

make generate-helm-docs generate-helm-schema

As per https://github.com/cert-manager/csi-driver/blob/main/RELEASE.md#preparing-for-a-release

BEFORE doing a release, check if the other images in the csi-driver Helm chart need to be updated.
These are:
registry.k8s.io/sig-storage/livenessprobe (.Values.livenessProbeImage.tag)
registry.k8s.io/sig-storage/csi-node-driver-registrar (.Values.nodeDriverRegistrarImage.tag)

$ crane ls registry.k8s.io/sig-storage/livenessprobe -O | sort -V | tail -n 1
v2.16.0
$ crane ls registry.k8s.io/sig-storage/csi-node-driver-registrar -O | sort -V | tail -n 1
v2.14.0

make generate-helm-docs generate-helm-schema

Signed-off-by: Richard Wall <[email protected]>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2025
@wallrj wallrj changed the title Bump sidecar images Bump sidecar images in preparation for release Jun 26, 2025
@wallrj wallrj requested a review from inteon June 26, 2025 15:39
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@cert-manager-prow cert-manager-prow bot merged commit 75b5e0e into cert-manager:main Jun 26, 2025
5 checks passed
@wallrj wallrj deleted the update-sidecar-images branch June 26, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants