Skip to content
This repository was archived by the owner on May 19, 2020. It is now read-only.

Update eslint-plugin-react-hooks to latest major release #37

Merged
merged 3 commits into from
Aug 30, 2019
Merged

Update eslint-plugin-react-hooks to latest major release #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98c8d7a
Update package.json
bjankord Aug 22, 2019
ea0c176
Update CHANGELOG.md
bjankord Aug 22, 2019
2173277
Update eslint.config.js
bjankord Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ ChangeLog

Unreleased
-----------------
### Changed
* Update eslint-plugin-react-hooks dependency to `^2.0.1`

3.0.0 - (August 20, 2019)
-----------------
Expand Down
1 change: 1 addition & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ module.exports = {
'react/forbid-component-props': [2, { forbid: ['style'] }],
'react/forbid-dom-props': [2, { forbid: ['style'] }],
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'warn',
'react/jsx-props-no-spreading': 'off',
'react/state-in-constructor': 'off',
'react/jsx-fragments': 'off',
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-jsx-a11y": "^6.1.1",
"eslint-plugin-react": "^7.12.2",
"eslint-plugin-react-hooks": "^1.0.0"
"eslint-plugin-react-hooks": "^2.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we major version bumping this package again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was this version adds a lint rule around usage of hooks at top level which crashes the app.

So before if you used hooks at top level; the app will crash. With pulling in this version now, if you use hooks at top level, you'll get a lint warning + app still crashes.

Based on that I'm leaning towards treating this as a minor release, however the react team considered this a breaking change.

Copy link
Contributor

@emilyrohrbough emilyrohrbough Aug 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my vote is ship it as a patch release lol because I'd agree this seems like a breaking change :/

},
"peerDependencies": {
"eslint": "^6.1.0"
Expand Down