Code Lint: Fix lint errors caused by revive check for unused parameters #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revive v1.3.7 added mgechev/revive#966 which checks for unused parameters in function literals. This caused several lint errors in go-ceph code. Signed-off-by: Manish <[email protected]>
ansiwen
added
the
no-API
ansiwen
approved these changes
Feb 13, 2024
ansiwen
reviewed
Feb 13, 2024
| @@ -26,7 +26,7 @@ type User struct { | |||
| UserQuota QuotaSpec `json:"user_quota"` | |||
| TempURLKeys []interface{} `json:"temp_url_keys"` | |||
| Type string `json:"type"` | |||
| MfaIds []interface{} `json:"mfa_ids"` | |||
There was a problem hiding this comment.
Oh, damn, I missed this one. We can't change that. That's external API. I will make a fix-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revive v1.3.7 added mgechev/revive#966 which checks for unused parameters in function literals. This caused several lint errors in go-ceph code.
Checklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.