Skip to content

Replace case.patching fixture with mockeypatch + MagicMock #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2023
Merged

Replace case.patching fixture with mockeypatch + MagicMock #692

merged 1 commit into from
Nov 8, 2023

Conversation

foarsitter
Copy link
Contributor

The amount of failing test-cases put my on the wrong foot since patching was used in an autouse fixture.

This PR has a minimal implementation of the patching fixture of case and drops case as dependency. as required in #691

@auvipy auvipy self-requested a review November 8, 2023 14:31
auvipy
auvipy approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@auvipy auvipy merged commit 0469120 into celery:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foarsitter @auvipy