improved wasm build process #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaobo-he-aws
approved these changes
May 31, 2024
cdisselkoen
approved these changes
May 31, 2024
| mkdir pkg | ||
| cargo build | ||
| wasm-pack build --scope cedar-policy --target bundler --out-dir pkg/esm | ||
| wasm-pack build --scope cedar-policy --target nodejs --out-dir pkg/nodejs |
There was a problem hiding this comment.
The readme says the subpackage is "node" but does this line mean it's actually "nodejs"?
There was a problem hiding this comment.
perhaps that's ugly... what controls the subpackage name is package.json
There was a problem hiding this comment.
changed the name of the subpackage in package.json to align with the naem of the wasm target
|
CI is failing with |
cdisselkoen
approved these changes
May 31, 2024
cdisselkoen
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: Victor Moreno <[email protected]>
cdisselkoen
added a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: Victor Moreno <[email protected]> Co-authored-by: Victor Moreno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
With this new build process, we accommodate all possible mechanisms for consuming wasm. The
nodetarget supports the needs of teams who can't use es-modules, and thewebtarget supports the needs of teams that need to read the wasm binary from a buffer for whatever reason.Issue #, if available
n/a
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):