Replace partial-validate with validation-mode in the CLI #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Magnus Markling <[email protected]>
memark
changed the title
Signed-off-by: Magnus Markling <[email protected]>
Signed-off-by: Magnus Markling <[email protected]>
memark
force-pushed
the
permissive-validation
branch
from
1035063 to
aadc14b
Compare
memark
changed the title
cdisselkoen
approved these changes
May 28, 2024
Contributor
cdisselkoen
left a comment
cdisselkoen
left a comment
There was a problem hiding this comment.
Looks great! It would also be great to add a line to the changelog in the cedar-policy-cli directory describing this change.
Signed-off-by: Magnus Markling <[email protected]>
memark
force-pushed
the
permissive-validation
branch
from
00d2ee3 to
1f45e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Support permissive-mode validation in the CLI by replacing the
--partial-validateoption with--validation-mode, taking the valuesstrict,permissiveorpartial. The latter two are kept behind their respective feature flags.Issue #, if available
Resolves #156
Checklist for requesting a review
Please tell me how and where you'd like me to document that.
I confirm that
cedar-spec(choose one, and delete the other options):