Removing error extension function
#874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khieta
approved these changes
May 15, 2024
khieta
reviewed
May 15, 2024
| /// Create a ternary (if-then-else) `Expr`. | ||
| /// Takes `Arc`s instead of owned `Expr`s | ||
| /// `test_expr` must evaluate to a Bool type | ||
| pub fn ite_arc(test_expr: Arc<Expr>, then_expr: Arc<Expr>, else_expr: Arc<Expr>) -> Self { |
There was a problem hiding this comment.
Nit: can we make it pub(crate)?
There was a problem hiding this comment.
Rest of the functions are not pub(crate), why this one?
There was a problem hiding this comment.
I think the signature of this function is not idiomatic as public functions. I was thinking another function as well but just commented on this one.
There was a problem hiding this comment.
This is just pub in Core, right? not re-exported in cedar-policy?
Signed-off-by: Aaron Eline <[email protected]>
aaronjeline
force-pushed
the
aaronjeline/no-more-error
branch
from
d3917c9 to
b56bbad
Compare
shaobo-he-aws
approved these changes
May 16, 2024
cdisselkoen
approved these changes
May 17, 2024
| /// Create a ternary (if-then-else) `Expr`. | ||
| /// Takes `Arc`s instead of owned `Expr`s | ||
| /// `test_expr` must evaluate to a Bool type | ||
| pub fn ite_arc(test_expr: Arc<Expr>, then_expr: Arc<Expr>, else_expr: Arc<Expr>) -> Self { |
There was a problem hiding this comment.
This is just pub in Core, right? not re-exported in cedar-policy?
2 tasks
Signed-off-by: Aaron Eline <[email protected]> Co-authored-by: Craig Disselkoen <[email protected]>
Signed-off-by: Aaron Eline <[email protected]> Co-authored-by: Craig Disselkoen <[email protected]>
|
Issue for re-increasing precision: #880 |
cdisselkoen
approved these changes
May 17, 2024
khieta
pushed a commit
that referenced
this pull request
Aug 9, 2024
Signed-off-by: Aaron Eline <[email protected]> Co-authored-by: Craig Disselkoen <[email protected]>
khieta
added a commit
that referenced
this pull request
Aug 9, 2024
Signed-off-by: Aaron Eline <[email protected]> Co-authored-by: Aaron Eline <[email protected]> Co-authored-by: Craig Disselkoen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Reduces the precision of partial evaluation when reducing expressions that are lazily evaluated (
ifandorsubexpressions). The primary motivation for this is removing theerrorextension function, which is impossible to type.Increases in precision without re-introducing
errorcould come later.Issue #, if available
N/A
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):