Fix formatter soundness check #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaobo He <[email protected]>
john-h-kastner-aws
approved these changes
May 13, 2024
Good idea. Working on it. |
Signed-off-by: Shaobo He <[email protected]>
Signed-off-by: Shaobo He <[email protected]>
khieta
approved these changes
May 13, 2024
Comment on lines
+148
to
+157
| let p1 = r#"permit (principal, action, resource) | ||
| when { " | ||
| a | ||
| " };"#; | ||
| let p2 = r#"permit (principal, action, resource) | ||
| when { " | ||
| a | ||
| " };"#; | ||
| assert!(soundness_check(p2, &parse_policyset(p1).unwrap()).is_err()); |
There was a problem hiding this comment.
Probably a dumb question, but why does the change in this PR help identify the issue in #862? Looking at the diff, it seems like the only change is to add a comparison of policy ids, which doesn't seem related.
Or is this test case unrelated to the changed code?
There was a problem hiding this comment.
templates() to policies() I think (line 45)
There was a problem hiding this comment.
Aha, thanks. @shaobo-he-aws can you add a description to the PR so it's easy not to miss this.
Comment on lines
-72
to
+80
| "policies differ in meaning or annotations:\noriginal: {p}\nformatted: {f_p}" | ||
| "policies differ in policy ids or meaning or annotations:\noriginal: {p}\nformatted: {f_p}" |
There was a problem hiding this comment.
Nit: probably easier for debugging if you separate these cases.
There was a problem hiding this comment.
I think I'll leave it to future work
3 tasks
khieta
pushed a commit
that referenced
this pull request
May 15, 2024
Signed-off-by: Shaobo He <[email protected]>
khieta
pushed a commit
that referenced
this pull request
May 15, 2024
Signed-off-by: Shaobo He <[email protected]>
khieta
pushed a commit
that referenced
this pull request
May 16, 2024
Signed-off-by: Shaobo He <[email protected]>
Merged
khieta
pushed a commit
that referenced
this pull request
May 16, 2024
Signed-off-by: Shaobo He <[email protected]>
khieta
pushed a commit
that referenced
this pull request
May 17, 2024
Signed-off-by: Shaobo He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
There were two issues with the original function.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):