Better error for action == ?action
#818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Kastner <[email protected]>
Signed-off-by: John Kastner <[email protected]>
aaronjeline
approved these changes
Apr 25, 2024
Signed-off-by: John Kastner <[email protected]>
shaobo-he-aws
approved these changes
Apr 25, 2024
2 tasks
john-h-kastner-aws
added a commit
that referenced
this pull request
May 6, 2024
Signed-off-by: John Kastner <[email protected]>
john-h-kastner-aws
added a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: John Kastner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #563
action == ?actionpreviously stated that itexpected single entity uid or set of entity uids, but this is incorrect for==.Fixed by first checking if the operator in the scope constraint is
==orin, and only callingto_refs_to_reffor theincase. The==case callsto_refwhich will correctly report that the RHS of the equality can only be a single entity and not a set of entities.This shouldn't be a breaking change even though I deleted a variant of
ToASTErrorKind. That error enum is not exported fromcedar-policy.Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
A bug fix or other functionality change requiring a patch to cedar-policy.
I confirm that this PR (choose one, and delete the other options):
Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
I confirm that
cedar-spec(choose one, and delete the other options):