Some quick updates to the PE api #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjeline
force-pushed
the
aaronjeline/pe-api-cleanup
branch
from
c926c6b to
e35ebc0
Compare
cdisselkoen
approved these changes
Apr 25, 2024
aaronjeline
force-pushed
the
aaronjeline/pe-api-cleanup
branch
from
e35ebc0 to
18d01ef
Compare
cdisselkoen
approved these changes
Apr 25, 2024
Signed-off-by: Aaron Eline <[email protected]> Co-authored-by: Craig Disselkoen <[email protected]>
aaronjeline
force-pushed
the
aaronjeline/pe-api-cleanup
branch
from
4b8a038 to
c404377
Compare
shaobo-he-aws
approved these changes
Apr 25, 2024
john-h-kastner-aws
approved these changes
Apr 25, 2024
3 tasks
john-h-kastner-aws
pushed a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: Aaron Eline <[email protected]> Co-authored-by: Craig Disselkoen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Some quick refinements based on public feedback:
may_be_determiningandmust_be_determiningnow returnPolicyinstead ofPolicyID. This makes iterating over them much more ergonomicgetnow return aPolicyinstead of anExpr, allowing you to grab the policy annotations as well if you want themnontrivial_residual_ids()as it's a trivial map onnontrivial_residualsnowIssue #, if available
N/A
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).I confirm that
cedar-spec(choose one, and delete the other options):